Use global token for controller #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
force-pushed
the
crd-global-token
branch
2 times, most recently
from
4525355
to
7b3e80c
Compare
lkysow
requested review from
a team,
kschoche and
ishustava
and removed request for
a team
lkysow
commented
Oct 29, 2020
| PolicyDCs: nil, | ||
| SecretNames: []string{resourcePrefix + "-controller-acl-token"}, | ||
| LocalToken: false, | ||
| }, | ||
| } |
There was a problem hiding this comment.
We were missing a bunch of tests for these tokens.
ishustava
approved these changes
Oct 30, 2020
CHANGELOG.md
Outdated
| @@ -1,5 +1,9 @@ | |||
| ## UNRELEASED | |||
|
|
|||
| BUG FIXES: | |||
| * CRDs: Ensure ACL token is global so that secondary DC's can manage custom resources. | |||
There was a problem hiding this comment.
Suggested change
| * CRDs: Ensure ACL token is global so that secondary DC's can manage custom resources. | |
| * CRDs: Ensure ACL token is global so that secondary DCs can manage custom resources. |
|
Waiting on #368 to be merged to avoid conflicts in that PR. |
|
This can be merged now @lkysow |
lkysow
force-pushed
the
crd-global-token
branch
from
7b3e80c
to
9a9d2ff
Compare
Controller token must be global because config entry writes all go to the primary datacenter. This means secondary datacenters need a token that is known by the primary datacenters.
lkysow
force-pushed
the
crd-global-token
branch
from
9a9d2ff
to
38fde58
Compare
ndhanushkodi
pushed a commit
to ndhanushkodi/consul-k8s
that referenced
this pull request
Jul 9, 2021
* helm3 support for NOTES.txt Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Controller token must be global because config entries are global and therefore all writes/reads
go to the primary datacenter. This means secondary datacenters need
a token that is known by the primary datacenters, i.e. a global token.
How I've tested this PR:
ghcr.io/lkysow/consul-k8s-dev:oct29How I expect reviewers to test this PR:
Checklist: