Backport of build: Create arm64 packages as well into release/1.2.x #3645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This probably needs to be manually backported as the automatic backport failed. |
dekimsey
force-pushed
the
backport/releng/package-additional-linux-architectures/personally-ready-heron
branch
from
6fa4df6
to
9fa4575
Compare
david-yu
approved these changes
Feb 20, 2024
During the CRT on-boarding, packaging for other Linux architectures (arm64) was not enabled. This change adds packaging support for those architectures. I've specifically opted not to include 32-bit. See #1132. Related to hashicorp/releng-support#178. Other related updates: - To make future support a bit easier, I've enabled the build workflow from releng prefixed branches. - Using qemu emulation for testing package installs on other architectures, thus allowing us to validate the binaries work as intended - Minor alteration to the package install tests to use yum instead of rpm
dekimsey
force-pushed
the
backport/releng/package-additional-linux-architectures/personally-ready-heron
branch
from
9fa4575
to
da8336f
Compare
david-yu
deleted the
backport/releng/package-additional-linux-architectures/personally-ready-heron
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #3428 to be assessed for backporting due to the inclusion of the label backport/1.2.x.
🚨
The person who merged in the original PR is:
@david-yu
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Changes proposed in this PR
During the CRT on-boarding, packaging for other Linux architectures (arm64) was
not enabled. This change adds packaging support for those architectures. I've
specifically opted not to include 32-bit.
Other related updates:
releng prefixed branches.
thus allowing us to validate the binaries work as intended
Note: I tried to add 386/arm packages but pivoted away. There's something suspicious with the 386 binary specifically (see comments). Since usage of that architecture is low, I punted.
How I've tested this PR
Please note, these packages have not been extensively tested on their respective platforms. I did update the pipeline to run the smoke test (consul version) against the arm64 packages in an arm64 user-space. So I think it's in a good place.
How I expect reviewers to test this PR
Download builds and test in the same manner existing binaries are tested. Docker containers would be sufficient.
Checklist
Tests addedRelated
See #1132.
Related to hashicorp/releng-support#178.
Overview of commits