-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of NET 6409 into release/1.3.x #3187
Merged
absolutelightning
merged 12 commits into
release/1.3.x
from
backport/NET-6409/oddly-tops-ringtail
Nov 8, 2023
Merged
Backport of NET 6409 into release/1.3.x #3187
absolutelightning
merged 12 commits into
release/1.3.x
from
backport/NET-6409/oddly-tops-ringtail
Nov 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/NET-6409/oddly-tops-ringtail
branch
from
November 8, 2023 05:22
fdfe780
to
21c8677
Compare
hc-github-team-consul-core
force-pushed
the
backport/NET-6409/oddly-tops-ringtail
branch
from
November 8, 2023 05:22
21c8677
to
fdfe780
Compare
absolutelightning
approved these changes
Nov 8, 2023
* init * fix help and synopsis * added some tests * change log * some fixes * rename var name * tests for get envoy stats * fix tests * Update cli/cmd/envoy-stats/envoy_stats.go Co-authored-by: Thomas Eckert <teckert@hashicorp.com> * proxy stats command * fix command options * pr comment resolved * fix globaloptions * fix lint --------- Co-authored-by: Thomas Eckert <teckert@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #3158 to be assessed for backporting due to the inclusion of the label backport/1.3.x.
🚨
The person who merged in the original PR is:
@absolutelightning
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Changes proposed in this PR:
Fixes - #2433
consul-k8s CLI: Display envoy cluster stats using consul-k8s CLI
How I've tested this PR:
make cli-dev
./consul-k8s proxy stats -pod nginx-6d7469694f-rdmwp -kubeconfig /Users/asheshvidyut/.kube/config -namespace default > nginx
cat nginx
How I expect reviewers to test this PR:
Checklist:
Overview of commits