Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of fix(controller): v2 pod controller errors for acl deletion into release/1.3.x #3177

Conversation

hc-github-team-consul-core

Backport

This PR is auto-generated from #3172 to be assessed for backporting due to the inclusion of the label backport/1.3.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR:

  • Don't error out if a token is missing metadata.
  • Make sure dataplane is injected with the correct metadata so that the ACL token is created with metadata on login.
  • Explicitly call stop when in the init container when re-direction is enabled.

How I've tested this PR: manual K8S testing plus unit tests.

How I expect reviewers to test this PR: 👁️ 👃 👁️

Checklist:


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/dans/NET-6298/v2-token-cleanup-errors/forcibly-quality-kid branch from 4857898 to e103240 Compare November 7, 2023 16:51
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/dans/NET-6298/v2-token-cleanup-errors/forcibly-quality-kid branch from c5b8546 to 021b126 Compare November 7, 2023 16:51
@hc-github-team-consul-core hc-github-team-consul-core merged commit 2b71660 into release/1.3.x Nov 7, 2023
25 of 49 checks passed
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/dans/NET-6298/v2-token-cleanup-errors/forcibly-quality-kid branch November 7, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants