Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/clly/observability credentials/manual #2973

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

clly
Copy link
Contributor

@clly clly commented Sep 19, 2023

Backport

This PR is a manual backport from #2958 to be assessed for backporting due to the inclusion of the label backport/1.2.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR:

  • When using the cloud preset, Attempt to fetch the observability credentials and use them when configuring the consul-telemetry-collector

How I've tested this PR:

  • unit tests
  • manual execution

How I expect reviewers to test this PR:

Checklist:


Overview of commits

Created by cherry-picking 1b52ac3

* feat: Add HCP Observability ClientID and ClientSecret

* go mod tidy

* changelog
@clly clly changed the base branch from main to release/1.2.x September 19, 2023 21:45
@clly clly marked this pull request as ready for review September 19, 2023 22:12
@clly clly enabled auto-merge (squash) September 19, 2023 22:22
@clly clly disabled auto-merge September 19, 2023 22:22
@clly clly added the pr/no-backport signals that a PR will not contain a backport label label Sep 20, 2023
@clly clly enabled auto-merge (squash) September 20, 2023 13:52
@clly clly merged commit 24b4a45 into release/1.2.x Sep 20, 2023
23 of 34 checks passed
@clly clly deleted the backport/clly/observability-credentials/manual branch September 20, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport signals that a PR will not contain a backport label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants