Respect allow/deny lists even when namespaces aren't enabled #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adilyse
force-pushed
the
inject-namespace-lists
branch
from
7dc0d15
to
ba63098
Compare
adilyse
requested review from
a team,
kschoche and
thisisnotashwin
and removed request for
a team
thisisnotashwin
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #296
Changes proposed in this PR:
How I've tested this PR:
Added tests to cover this scenario. Since the only functionality change is to the
shouldInjectmethod, this is sufficient.How I expect reviewers to test this PR:
Confirm that the
TestShouldInjecttest in connect-inject/handler_test.go works as expected and covers all the desired scenarios.Checklist: