Fix endpoints controller v2 tests #2968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalimeni
added
pr/no-changelog
DanStough
approved these changes
Sep 15, 2023
|
https://github.com/hashicorp/consul-k8s-workflows/actions/runs/6202272584/job/16840895107#step:11:1258 <- False alarm, 60d09e2#diff-4ac252d0326267867766a1e8845ab2d03a33ec3f2c4b4ecd86ded42086126a11R557 added a test that I didn't cover in the service accounts controller PR; the SHA above passed because it hadn't been rebased on that change. |
We now default unspecified ports to TCP; reflect this to unbreak tests.
zalimeni
force-pushed
the
zalimeni/fix-missing-constant-endpoints-controller-v2-test
branch
from
2575579
to
a09cd77
Compare
zalimeni
changed the title
zalimeni
deleted the
zalimeni/fix-missing-constant-endpoints-controller-v2-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The missing constant somehow slipped by in CI. Are we not running v2 tests? Fixing first before digging.
Also fixes test that is breaking due to a protocol defaulting fix in Consul merged today.