feat: add mesh-inject annotation to helm chart #2957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanStough
added
pr/no-changelog
zalimeni
approved these changes
Sep 14, 2023
DanStough
force-pushed
the
dans/add-v2-annotations-to-helm
branch
from
6d07113
to
e671bb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
consul.hashicorp.com/mesh-injectannotation to resources in the helm chart using V1consul.hashicorp.com/connect-inject. This is what the V2 Mesh webhook checks to determine injection.How I've tested this PR: Helm Unit tests, acceptance tests
How I expect reviewers to test this PR: 👀 and GHA
Checklist:
CHANGELOG entry added