Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of NET-5531 Translate response header modifier(s) from HTTPRoute onto Consul config entry into release/1.2.x #2951

Conversation

hc-github-team-consul-core

Backport

This PR is auto-generated from #2904 to be assessed for backporting due to the inclusion of the label backport/1.2.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@nathancoleman
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul-k8s/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Note
This PR depends on changes in hashicorp/consul#18646

Changes proposed in this PR:
Translate the responseHeaderModifier that already exists on the K8s HTTPRoute onto the http-route config entry in Consul, which accepts response header modifiers as of hashicorp/consul#18646.

This PR also addresses the fact that we write an empty header modifier to Consul today for request header modifications when the K8s HTTPRoute does not specify any header modifications. Instead, we now appropriately write an empty list of header modifications to Consul when the HTTPRoute does not specify any.

How I've tested this PR:
Create a K8s HTTPRoute with various response header modifier filter(s) and verify that the filter syncs into Consul and functions correctly. See video of my own testing.

In addition, conformance tests exist here for this functionality that should pass where they previously failed. Here is the output of those tests passing.
CleanShot 2023-09-12 at 11 54 23@2x

How I expect reviewers to test this PR:
See above

Checklist:


Overview of commits

@hashicorp-cla
Copy link

hashicorp-cla commented Sep 12, 2023

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@nathancoleman
Copy link
Member

Decided not to backport

@nathancoleman nathancoleman deleted the backport/response-headers/adequately-perfect-cougar branch September 12, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants