Backport of NET-4413 Implement translation + validation of TLS options into release/1.2.x #2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/validate-tls-opts/usefully-dashing-tomcat
branch
14 times, most recently
from
9751643
to
600996d
Compare
* Implement validation of TLS options * Use constants for annotation keys * Add changelog entry * Implement TLS options translation * Update changelog entry * Add unit test coverage for TLS option validation * Code review feedback
nathancoleman
force-pushed
the
backport/validate-tls-opts/usefully-dashing-tomcat
branch
from
0b08fa3
to
7fb117a
Compare
hc-github-team-consul-core
deleted the
backport/validate-tls-opts/usefully-dashing-tomcat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #2711 to be assessed for backporting due to the inclusion of the label backport/1.2.x.
The below text is copied from the body of the original PR.
Changes proposed in this PR:
Gatewayresource in K8s and write them to theapi-gatewayconfig entry in ConsulHow I've tested this PR:
How I expect reviewers to test this PR:
Checklist:
Overview of commits