Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -resolve-hostnames flag #271

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Add -resolve-hostnames flag #271

merged 1 commit into from
Jun 8, 2020

Commits on Jun 3, 2020

  1. Add -resolve-hostnames flag

    Add a -resolve-hostnames flag to the service-address command that
    defaults to false. If true, any service with a hostname as its address
    will have that hostname resolved and the first ip written.
    
    If false, the hostname will be written.
    
    This is useful in the case of EKS where load balancers have hostnames.
    For WAN federation we want to use the hostname because the underlying
    IPs can change. For ingress gateways this command is used to set the
    address field in the service definition which only accepts IPs. This
    flag allows the service-address command to be used so the service
    registration is valid and then we document that in the EKS case users
    shouldn't use the ingress consul DNS and should instead set up their own
    DNS that resolves to the load balancer.
    lkysow committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    7ea39c5 View commit details
    Browse the repository at this point in the history