Backport of NET-4638: when multiple listeners have the same port, only add to K8s Service once into release/1.2.x #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/NET-4638-duplicate-listener-ports/personally-many-reptile
branch
from
4200559
to
bebd966
Compare
hc-github-team-consul-core
force-pushed
the
backport/NET-4638-duplicate-listener-ports/personally-many-reptile
branch
from
7107063
to
2aa9fac
Compare
nathancoleman
force-pushed
the
backport/NET-4638-duplicate-listener-ports/personally-many-reptile
branch
from
2aa9fac
to
76a6e44
Compare
nathancoleman
approved these changes
Jul 12, 2023
hc-github-team-consul-core
deleted the
backport/NET-4638-duplicate-listener-ports/personally-many-reptile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #2413 to be assessed for backporting due to the inclusion of the label backport/1.2.x.
The below text is copied from the body of the original PR.
Changes proposed in this PR:
A valid
Gatewaycan have multiple listeners with the same port. When this happens, we loop through the listeners and add each listener's port to the list of ports for the corresponding KubernetesService, resulting in an invalid resource that can't be created.This change just tracks which ports have already been added so that we only add each port once.
How I've tested this PR:
🤖 tests pass
How I expect reviewers to test this PR:
🤖 tests pass
Checklist:
Overview of commits