-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mw/net 4605 consul k8s pin cloud tests to latest supported kubernetes version for that release 1 0 #2464
Conversation
3744f16
to
6f828f0
Compare
@@ -45,7 +55,7 @@ resource "azurerm_kubernetes_cluster" "default" { | |||
location = azurerm_resource_group.default[count.index].location | |||
resource_group_name = azurerm_resource_group.default[count.index].name | |||
dns_prefix = "consul-k8s-${random_id.suffix[count.index].dec}" | |||
kubernetes_version = "1.24.6" | |||
kubernetes_version = "1.25" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only field modified from the cherrypick
@@ -58,7 +68,7 @@ module "eks" { | |||
kubeconfig_api_version = "client.authentication.k8s.io/v1beta1" | |||
|
|||
cluster_name = "consul-k8s-${random_id.suffix[count.index].dec}" | |||
cluster_version = "1.23" | |||
cluster_version = "1.25" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only field modified from the cherrypick
.github/workflows/pr.yml
Outdated
@@ -18,7 +18,7 @@ jobs: | |||
- uses: benc-uk/workflow-dispatch@v1.2.2 | |||
name: test | |||
with: | |||
workflow: test.yml | |||
workflow: cloud.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to drop this
* update eks and aks to use latest kubernetes version * updated the terraform provider as some fields were deprecated
6f828f0
to
5614f07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for updating the terraform versions too!
Changes proposed in this PR:
1.0
which is kubernetes1.25
How I've tested this PR:
https://github.com/hashicorp/consul-k8s-workflows/actions/runs/5392938127/jobs/9793690720
How I expect reviewers to test this PR:
👀
Checklist: