Mw/net 4605 consul k8s pin cloud tests to latest supported kubernetes version for that release 1 0 #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilkermichael
added
pr/no-backport
wilkermichael
force-pushed
the
mw/NET-4605-Consul-k8s-Pin-Cloud-tests-to-latest-supported-kubernetes-version-for-that-release-1-0
branch
from
3744f16
to
6f828f0
Compare
wilkermichael
commented
Jun 27, 2023
| @@ -45,7 +55,7 @@ resource "azurerm_kubernetes_cluster" "default" { | |||
| location = azurerm_resource_group.default[count.index].location | |||
| resource_group_name = azurerm_resource_group.default[count.index].name | |||
| dns_prefix = "consul-k8s-${random_id.suffix[count.index].dec}" | |||
| kubernetes_version = "1.24.6" | |||
| kubernetes_version = "1.25" | |||
There was a problem hiding this comment.
This is the only field modified from the cherrypick
wilkermichael
commented
Jun 27, 2023
| @@ -58,7 +68,7 @@ module "eks" { | |||
| kubeconfig_api_version = "client.authentication.k8s.io/v1beta1" | |||
|
|
|||
| cluster_name = "consul-k8s-${random_id.suffix[count.index].dec}" | |||
| cluster_version = "1.23" | |||
| cluster_version = "1.25" | |||
There was a problem hiding this comment.
This is the only field modified from the cherrypick
wilkermichael
commented
Jun 27, 2023
.github/workflows/pr.yml
Outdated
| @@ -18,7 +18,7 @@ jobs: | |||
| - uses: benc-uk/workflow-dispatch@v1.2.2 | |||
| name: test | |||
| with: | |||
| workflow: test.yml | |||
| workflow: cloud.yml | |||
There was a problem hiding this comment.
Don't forget to drop this
* update eks and aks to use latest kubernetes version * updated the terraform provider as some fields were deprecated
wilkermichael
force-pushed
the
mw/NET-4605-Consul-k8s-Pin-Cloud-tests-to-latest-supported-kubernetes-version-for-that-release-1-0
branch
from
6f828f0
to
5614f07
Compare
ndhanushkodi
approved these changes
Jun 28, 2023
wilkermichael
deleted the
mw/NET-4605-Consul-k8s-Pin-Cloud-tests-to-latest-supported-kubernetes-version-for-that-release-1-0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
1.0which is kubernetes1.25How I've tested this PR:
https://github.com/hashicorp/consul-k8s-workflows/actions/runs/5392938127/jobs/9793690720
How I expect reviewers to test this PR:
👀
Checklist: