Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual backport of 2337 into release/1.1.x #2455

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Manual backport of 2337 into release/1.1.x #2455

merged 1 commit into from
Jun 26, 2023

Conversation

curtbushko
Copy link
Contributor

Changes proposed in this PR:

How I've tested this PR:

👀

How I expect reviewers to test this PR:

👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@curtbushko curtbushko added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label labels Jun 26, 2023
@curtbushko curtbushko self-assigned this Jun 26, 2023
@curtbushko curtbushko merged commit c380a11 into release/1.1.x Jun 26, 2023
@curtbushko curtbushko deleted the backport-2337-into-release-1.1.x branch June 26, 2023 16:11
skpratt added a commit that referenced this pull request Jul 19, 2023
@skpratt
Revert "Manual backport of 2337 into release/1.1.x (#2455)"
10a0a39 
This reverts commit c380a11.
@skpratt skpratt mentioned this pull request Jul 19, 2023
Merged
skpratt added a commit that referenced this pull request Jul 19, 2023
@skpratt
Revert "Manual backport of 2337 into release/1.1.x" (#2588)
239c8f5 
Reverts #2455
This should not have been backported to 1.1.x (it was labeled
incorrectly in #2337),
because it changes the RedHat registry ID to the FIPS one. It has been
reverted in the other backport branches:
#2504
#2559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-yu david-yu david-yu approved these changes

@wilkermichael wilkermichael Awaiting requested review from wilkermichael

Assignees

@curtbushko curtbushko

Labels
pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curtbushko @david-yu