Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server-acl-init: Add -server-address and -server-port #238

Merged
merged 4 commits into from
Apr 9, 2020
Merged

server-acl-init: Add -server-address and -server-port #238

merged 4 commits into from
Apr 9, 2020

Commits on Apr 8, 2020

  1. server-acl-init: Add -server-address and -server-port 

    * Require -server-address to be provided instead of discovering the
  server IPs from Kubernetes pods. This allows us to eventually
  to run this command against external servers or servers deployed
  on Kube in the same way. On Kubernetes, instead of discovering Pod IPs,
  we can use server's stateful set DNS names.
* [Breaking change] Remove -expected-replicas, -release-name, and
  -server-label-selector flags because we no longer need them.
    @ishustava
    ishustava committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    c2581c5 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2020

  1. Improvements from code review

    @ishustava
    ishustava committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    76a2e10 View commit details
    Browse the repository at this point in the history

  2. Remove Pod refs

    @ishustava
    ishustava committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    c702a2e View commit details
    Browse the repository at this point in the history

  3. Update comment

    @ishustava
    ishustava committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    853ae2b View commit details
    Browse the repository at this point in the history