Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -token-sink-file flag to acl-init #232

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Mar 11, 2020

Add flag -token-sink-file to acl-init command. If init-type=sync (which is used for everything except consul agents) then if -token-sink-file is set, we will write the token to that file.

This is needed for the mesh-gateway lifecycle sidecar (hashicorp/consul-helm#380)

@adilyse adilyse added area/acls Related to ACLs type/enhancement New feature or request labels Mar 12, 2020
@lkysow lkysow requested a review from a team March 16, 2020 18:58
@lkysow lkysow changed the base branch from master to wan-federation-base March 16, 2020 19:11
@lkysow lkysow marked this pull request as ready for review March 18, 2020 16:50
@lkysow lkysow added the area/multi-dc Related to running with multiple datacenters label Mar 18, 2020
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Luke, lgtm! I've left a couple of comments inline. I don't think they are blocking, so I'll approve. But if you want me to re-review, I'm more than happy to 😄

subcommand/acl-init/command.go Outdated Show resolved Hide resolved
subcommand/acl-init/command_test.go Outdated Show resolved Hide resolved
If this flag is set then we will write the acl token
to that file.

Also remove -init-type=sync. If -init-type was set
to sync the behaviour didn't change so remove that
from the docs.
@lkysow lkysow merged commit 6c6e52f into wan-federation-base Mar 23, 2020
@lkysow lkysow deleted the acl-init-token-write branch March 23, 2020 17:57
lkysow added a commit to hashicorp/consul-helm that referenced this pull request Mar 23, 2020
As part of hashicorp/consul-k8s#232 we removed
the docs about -init-type=sync. If -init-type was set to sync it
actually had no effect. Only -init-type=client had effect so this change
stops setting that flag in the case of sync.
lkysow added a commit to hashicorp/consul-helm that referenced this pull request Mar 30, 2020
As part of hashicorp/consul-k8s#232 we removed
the docs about -init-type=sync. If -init-type was set to sync it
actually had no effect. Only -init-type=client had effect so this change
stops setting that flag in the case of sync.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/acls Related to ACLs area/multi-dc Related to running with multiple datacenters type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants