Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allow all intention for consul-telemetry-collector for -demo #2262

Merged
merged 2 commits into from
Jun 2, 2023

Conversation

jjti
Copy link
Contributor

@jjti jjti commented Jun 2, 2023

Changes proposed in this PR:

  • This allowlists all traffic to consul-telemetry-collector for with using consul-k8s -demo

How I've tested this PR:

How I expect reviewers to test this PR:

export HCP_API_HOST=https://api.hcp.dev
export HCP_AUTH_URL=https://auth.idp.hcp.dev
export HCP_SCADA_ADDRESS=scada.internal.hcp.dev:7224

HCP_CLIENT_ID=x HCP_CLIENT_SECRET=y consul-k8s install -preset cloud -hcp-resource-id $RESOURCE_ID -demo \
	--set="global.enterpriseLicense.secretName=consul-license" \
	--set="global.enterpriseLicense.secretKey=key" \
	--set="global.image=hashicorp/consul:1.15.3" \
	--set="server.replicas=3" \
	--set="peering.enabled=true" \
	--set="meshGateway.enabled=true" \
	--set="meshGateway.service.type=ClusterIP" \
	--set="global.logLevel=debug" \
	--set="metrics.enableTelemetryCollector=true" \
	--set="global.imageConsulDataplane=hashicorppreview/consul-dataplane:1.1-dev" \
  --set="telemetryCollector.image=hashicorppreview/consul-telemetry-collector:0.0.0-dev"

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@jjti jjti added pr/no-backport signals that a PR will not contain a backport label backport/1.1.x Backport to release/1.1.x branch and removed pr/no-backport signals that a PR will not contain a backport label labels Jun 2, 2023
Copy link
Contributor

@t-eckert t-eckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition to the demo

@jjti jjti merged commit 4435e14 into release/1.1.x Jun 2, 2023
@jjti jjti deleted the jjtimmons/allowlist-collector-demo branch June 2, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.1.x Backport to release/1.1.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants