-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NET-1374] #2166
Merged
Merged
[NET-1374] #2166
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
c614f03
bootstrap control plane request limits
loshz d69e4d6
ctrl-generate
DanStough 4df9ae7
implement ConfigEntryResource
loshz e5cda85
add changelog
loshz 7e9895b
add control-plane tests
loshz 80a6651
controllers: add test cases
loshz 9e04086
api: add webhook
loshz dac0b31
Update command.go
loshz 68a9b28
generate yaml
loshz f734677
update helm chart
loshz 68df878
Update .changelog/2166.txt
loshz bde72dd
rm unused generated files
loshz 96a442e
add copywrite headers
loshz 9e296af
add handle and validate logic
loshz f32584d
fix lint issues
loshz ad4c5b9
fix lint issues
loshz 367fc16
go mod tidy
jmurret 7b78bf3
update controller to use subresources
jmurret a18cb05
fixing unit test so it matches on correct config entry
jmurret cf3fc91
fixing copy pasta
jmurret 8202802
fixing broken unit tests. adding piece to acceptance tests.
jmurret a16b36b
updating tests
jmurret 8525a31
marking crd as requiring connectInject.enabled
jmurret 76acabd
removed readrate and writerate checks for < 0
jmurret 3dfe0e2
fixing copy pasta in controlplanerequestlimit_webhook.go to reference…
jmurret 54b8452
putting removed copyright header back
jmurret 39c138f
fixing lint errors
jmurret 8e10b1c
fixup generated CRDs
thisisnotashwin c2b25c2
add type tests
loshz 6e9ffd3
fixup generated CRDs
thisisnotashwin c55718d
add webhook tests
loshz 725f45b
fix lint issues
loshz 2c38012
add namespace acceptance tests
loshz 729fd20
commenting out prepared query to validate why acceptance tests are fa…
thisisnotashwin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
```release-note:feature | ||
Add support for configuring Consul server-side rate limiting | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
acceptance/tests/fixtures/bases/crds-oss/controlplanerequestlimit.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
# Copyright (c) HashiCorp, Inc. | ||
# SPDX-License-Identifier: MPL-2.0 | ||
|
||
apiVersion: consul.hashicorp.com/v1alpha1 | ||
kind: ControlPlaneRequestLimit | ||
metadata: | ||
name: controlplanerequestlimit | ||
spec: | ||
mode: "permissive" | ||
readRate: 100.0 | ||
writeRate: 100.0 | ||
acl: | ||
readRate: 100.0 | ||
writeRate: 100.0 | ||
catalog: | ||
readRate: 100.0 | ||
writeRate: 100.0 | ||
configEntry: | ||
readRate: 100.0 | ||
writeRate: 100.0 | ||
connectCA: | ||
readRate: 100.0 | ||
writeRate: 100.0 | ||
coordinate: | ||
readRate: 100.0 | ||
writeRate: 100.0 | ||
discoveryChain: | ||
readRate: 100.0 | ||
writeRate: 100.0 | ||
health: | ||
readRate: 100.0 | ||
writeRate: 100.0 | ||
intention: | ||
readRate: 100.0 | ||
writeRate: 100.0 | ||
kv: | ||
readRate: 100.0 | ||
writeRate: 100.0 | ||
tenancy: | ||
readRate: 100.0 | ||
writeRate: 100.0 | ||
# preparedQuery: | ||
# readRate: 100.0 | ||
# writeRate: 100.0 | ||
session: | ||
readRate: 100.0 | ||
writeRate: 100.0 | ||
txn: | ||
readRate: 100.0 | ||
writeRate: 100.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing an assertion that the resource has been deleted. Additionally, these steps need to be copied over to the namespaces test. you can copy paste them for the most part but you will need to add some
-n kubens
flags here and there. it should be clear in the test itself.