Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of GHA: Get the consul version from values.yaml into release/1.1.x #2149

Conversation

hc-github-team-consul-core

Backport

This PR is auto-generated from #2146 to be assessed for backporting due to the inclusion of the label backport/1.1.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR:

  • The release branches are running the wrong version of consul in the tests.
  • This let's us run make consul-version to pull the consul version out of the values.yaml file so that we can use the correct consul version on the release branches.
  • I will do a change on the github actions side once this is merged and backported

How I've tested this PR:

  • Ran the make target locally (yq is installed on the runners so it should succeed there too)

How I expect reviewers to test this PR:

👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/curtbushko/get-consul-version/physically-quick-cub branch from 4f26e73 to bbbd9f9 Compare May 17, 2023 22:27
@hc-github-team-consul-core hc-github-team-consul-core merged commit f1bd549 into release/1.1.x May 17, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/curtbushko/get-consul-version/physically-quick-cub branch May 17, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants