-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APIGW4CONK8s: Add Consul Cache #2118
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
dcdd52e
Added basic cache functionality with most tests, todo: add get method
jm96441n 3d216f9
Updated tests for Cache.Run function, removed tests of unexported
jm96441n 446bd88
Moved translation function def to translation package, added translate
jm96441n 39fb469
Add translation for consul config entries to k8s namespaced name meta
jm96441n 00f97d0
Added Get method to cache
jm96441n 9f7b0fe
Add watch for contoller and setup in inject command
jm96441n 215891c
Updated comments, renamed TranslateConsulInlineSecret method to
jm96441n 56575d9
Updates from PR review
jm96441n c2d5921
Parallelize tests
jm96441n c074b0f
Bump consul api version
jm96441n 7dcbe18
Set api timeout for cache calls
jm96441n 9fa1dfe
Revert "Bump consul api version"
jm96441n d17db20
Linting fun
jm96441n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this came from the POC implementation
consul-k8s/control-plane/controller/apigateway_controller.go
Line 416 in 408114a
metaKeyKubeService
name elsewhere in this repo (or do we use both keys in the meta?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can keep it around and if we get to the end of the implementation and find that we aren't using it, we can toss it.