Define sync channels without creating and closing them #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a sync direction was disabled, the closing of a channel that wasn't used again was causing the entire program to exit as if there was an error. Switched these channels to be created with `var` instead, which stops this unexpected behavior.
mitchellh
suggested changes
Oct 18, 2018
|
Good catch! I've added nil checks within all of the different cases in that select statement. |
mitchellh
approved these changes
Oct 19, 2018
There was a problem hiding this comment.
Looks good.
In general we usually unit test our commands. Its my fault that these aren't unit tested (i.e. Consul CLI is all unit tested). I'll try to add some unit tests so I can lay the groundwork since it was my mess to start with. 😄I would merge this as-is though, just noting!
|
hey @adilyse, thanks for this. do you have any estimation of when a new docker image will be released? |
|
@jondeandres This is fix is now available in v0.2.1, just released! |
|
hey @adilyse,thank you very much, I will try it today. Thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7.
When a sync direction was disabled, the closing of a channel that
wasn't used again was causing the entire program to exit as if there
was an error.
Switched these channels to be created with
varinstead, whichstops this unexpected behavior.