Backport of Add global.extraLabels values.yaml setting into release/0.49.x #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes temp seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
|
backported manually #1778 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #1771 to be assessed for backporting due to the inclusion of the label backport/0.49.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Currently, there isn't a way to add a set of labels to every pod (see #759 for example). This PR adds a global values.yaml setting that lets you specify labels to apply to every pod/deployment/daemonset/statefulset/job created by the helm chart. This is in addition to the existing
extraLabelsconfig for things like clients and servers.Changes proposed in this PR:
global.extraLabelsvalues.yaml settingHow I've tested this PR:
Added bats tests to cover testing extra labels for all applicable resources
How I expect reviewers to test this PR:
Run the tests, maybe deploy the helm chart locally just to make sure it works
Checklist:
Overview of commits