-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove controller from preset values file #1755
Remove controller from preset values file #1755
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks for this, I'd had this fix in the back of my mind and didn't circle back to it yet!
Since your PR didn't run any of the unit tests (because it's a fork PR I'm guessing) it'd be great to confirm that all the tests still pass manually if you have a chance!
@kschoche, thank you for reviewing. Should we also get rid of |
@Ranjandas - Thanks! To run the tests, I believe you should be okay running
But you definitely have a valid point about the |
Thank you so much @kschoche. I have updated the tests and fixed all failures.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most excellent work, thank you!
I noticed we also have some docs cleanup on this front as well to remove the controller references, if you have time. Otherwise it's definitely not blocking this PR from going in!
website/content/docs/k8s/installation/install-cli.mdx
@kschoche I have updated the doc. Could you please review and help get both PRs merged? |
* Remove controller from preset values file in CLI
Changes proposed in this PR:
controller: true
from the preset values file as the controller is now part of connectInject 1697How I've tested this PR:
I built a binary and tried installing using the modified presets.
How I expect reviewers to test this PR:
Checklist: