CNI acceptance tests on AKS #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
approved these changes
Aug 25, 2022
curtbushko
force-pushed
the
curtbushko/cni-acceptance-aks
branch
from
0c8798f
to
abd14b8
Compare
ishustava
approved these changes
Aug 25, 2022
curtbushko
force-pushed
the
curtbushko/cni-acceptance-aks
branch
from
abd14b8
to
9d913c3
Compare
- Added a new make target for installing Calico CNI in Kind. The target installs Calico CNI using config files located under /acceptance tests - Added a helper make target for setting up local Kind with Calico just in case anyone wants to run it. - Added a kind.config for setting up the Kind cluster - Added an -enable-cni flag to the acceptance test config so that it can be passed through from CircleCI - Added a nightly circleci job for running the CNI kind tests - I had missed a bats test for the connect-inject template that I merged in a previous PR
…connectInject.cni.enabled from several files as the framework will set this when the flag is passed in
curtbushko
force-pushed
the
curtbushko/cni-acceptance-aks
branch
from
9d913c3
to
53c2d4c
Compare
curtbushko
added a commit
that referenced
this pull request
Aug 26, 2022
- Add AKS as a nightly acceptance test job - Pulled in an updated version of AKS because Azure deprecated the version we were using - Some policy changes pulled in from the GKE PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of the CNI acceptance tests on Kind branch/PR to get things running on AKS. I also pull in a couple policy changes from the CNI acceptance on GKE branch to make sure that piece is working.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
👀
Checklist: