Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNI Acceptance tests on EKS #1447

Merged
merged 8 commits into from
Aug 25, 2022
Merged

CNI Acceptance tests on EKS #1447

merged 8 commits into from
Aug 25, 2022

Conversation

curtbushko
Copy link
Contributor

This PR builds on top of the CNI acceptance on Kind branch/PR to get things running on EKS. I also pull in a couple policy changes from the CNI acceptance on GKE branch to make sure that piece is working.

Changes proposed in this PR:

  • Add EKS as a nightly acceptance test job

How I've tested this PR:

  • ran the tests against EKS

How I expect reviewers to test this PR:

👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@curtbushko curtbushko self-assigned this Aug 25, 2022
@@ -1093,6 +1157,11 @@ workflows:
# requires:
# - cleanup-eks-resources
# - dev-upload-docker
- acceptance-eks-cni-1-19:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will clean this up before merge

Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:chefkiss:

Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work ❤️

Base automatically changed from curtbushko/cni-acceptance-kind to cni August 25, 2022 19:23
@curtbushko curtbushko force-pushed the curtbushko/cni-acceptance-eks branch from a4e9791 to 62426ba Compare August 25, 2022 19:51
-  Added a new make target for installing Calico CNI in Kind. The target installs Calico CNI using config files located under /acceptance tests
- Added a helper make target for setting up local Kind with Calico just in case anyone wants to run it.
- Added a kind.config for setting up the Kind cluster
- Added an -enable-cni flag to the acceptance test config so that it can be passed through from CircleCI
-  Added a nightly circleci job for running the CNI kind tests
-  I had missed a bats test for the connect-inject template that I merged in a previous PR
…connectInject.cni.enabled from several files as the framework will set this when the flag is passed in
@curtbushko curtbushko force-pushed the curtbushko/cni-acceptance-eks branch from 82864d3 to 976b5bb Compare August 25, 2022 22:01
@curtbushko curtbushko merged commit 1e7e5ef into cni Aug 25, 2022
@curtbushko curtbushko deleted the curtbushko/cni-acceptance-eks branch August 25, 2022 22:04
curtbushko added a commit that referenced this pull request Aug 26, 2022
Add EKS as a nightly acceptance test job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants