Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix acceptance tests passing "-config" instead of "-kubeconfig" to CLI #1427

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Fix acceptance tests passing "-config" instead of "-kubeconfig" to CLI #1427

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fbd53e
config -> kubeconfig
Aug 16, 2022
4491a11
Run GKE Acceptance
Aug 16, 2022
958669f
Stop GKE acceptance tests running on PRs
Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1000,6 +1000,11 @@ workflows:
requires:
- build-distros-linux
# Run acceptance tests using the docker image built for the control plane
- cleanup-gcp-resources
- acceptance-gke-1-20:
requires:
- cleanup-gcp-resources
- dev-upload-docker
t-eckert marked this conversation as resolved.
Show resolved Hide resolved
- acceptance:
context: consul-ci
requires:
Expand Down
2 changes: 1 addition & 1 deletion acceptance/framework/cli/cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func (c *CLI) Run(t *testing.T, options *k8s.KubectlOptions, args ...string) ([]

// Append configuration from `options` to the command.
if options.ConfigPath != "" {
args = append(args, "-config", options.ConfigPath)
args = append(args, "-kubeconfig", options.ConfigPath)
}
if options.ContextName != "" {
args = append(args, "-context", options.ContextName)
Expand Down