Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests #1313

Merged
merged 6 commits into from
Jul 6, 2022
Merged

Tests #1313

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7e76901
fix dataDirectoryHostPath tests
eb4x Jun 29, 2022
fd84db2
fix test comparison
eb4x Jun 29, 2022
878741e
select named initContainers
eb4x Jun 29, 2022
09f6bbc
simplify yq queries
eb4x Jun 29, 2022
62edc36
check all of env for CONSUL_HTTP_TOKEN_FILE
eb4x Jul 4, 2022
7178b99
Re-word tests with has("securityContext")
eb4x Jul 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 36 additions & 36 deletions charts/consul/test/unit/client-daemonset.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1192,7 +1192,7 @@ local actual=$(echo $object |
-s templates/client-daemonset.yaml \
--set 'global.acls.manageSystemACLs=false' \
. | tee /dev/stderr |
yq '[.spec.template.spec.containers[0].env[0].name] | any(contains("CONSUL_HTTP_TOKEN_FILE"))' | tee /dev/stderr)
yq '[.spec.template.spec.containers[] | select(.name == "consul") | .env[] | .name] | any(contains("CONSUL_HTTP_TOKEN_FILE"))' | tee /dev/stderr)
[ "${actual}" = "false" ]
}

Expand All @@ -1202,7 +1202,7 @@ local actual=$(echo $object |
-s templates/client-daemonset.yaml \
--set 'global.acls.manageSystemACLs=true' \
. | tee /dev/stderr |
yq '[.spec.template.spec.containers[0].env[0].name] | any(contains("CONSUL_HTTP_TOKEN_FILE"))' | tee /dev/stderr)
yq '[.spec.template.spec.containers[] | select(.name == "consul") | .env[] | .name] | any(contains("CONSUL_HTTP_TOKEN_FILE"))' | tee /dev/stderr)
[ "${actual}" = "true" ]
}

Expand Down Expand Up @@ -1277,7 +1277,7 @@ local actual=$(echo $object |
-s templates/client-daemonset.yaml \
--set 'global.acls.manageSystemACLs=true' \
--set 'global.tls.enabled=true' \
. | yq '.spec.template.spec.initContainers[0].volumeMounts[2]' | tee /dev/stderr)
. | yq '.spec.template.spec.initContainers[] | select(.name == "client-acl-init") | .volumeMounts[] | select(.name == "consul-ca-cert")' | tee /dev/stderr)

local actual=$(echo $object |
yq -r '.name' | tee /dev/stderr)
Expand All @@ -1298,8 +1298,8 @@ local actual=$(echo $object |
-s templates/client-daemonset.yaml \
--set 'global.acls.manageSystemACLs=true' \
--set 'global.tls.enabled=false' \
. | yq '.spec.template.spec.initContainers[0].volumeMounts[] | select(.name=="consul-ca-cert")' | tee /dev/stderr)
[ "${actual}" == "" ]
. | yq '.spec.template.spec.initContainers[] | select(.name == "client-acl-init") | .volumeMounts[] | select(.name=="consul-ca-cert")' | tee /dev/stderr)
[ "${object}" == "" ]
}

@test "client/DaemonSet: fail when externalServers is enabled but the externalServers.hosts is not provided" {
Expand All @@ -1325,7 +1325,7 @@ local actual=$(echo $object |
--set 'externalServers.hosts[0]=foo' \
--set 'externalServers.hosts[1]=bar' \
. | tee /dev/stderr |
yq -r '.spec.template.spec.initContainers[0].command' | tee /dev/stderr)
yq -r '.spec.template.spec.initContainers[] | select(.name == "client-acl-init") | .command' | tee /dev/stderr)

local actual=$(echo $command | jq -r ' . | any(contains("-server-address=\"foo\""))' | tee /dev/stderr)
[ "${actual}" = "true" ]
Expand All @@ -1345,7 +1345,7 @@ local actual=$(echo $object |
--set 'externalServers.hosts[0]=computer' \
--set 'externalServers.tlsServerName=foo' \
. | tee /dev/stderr |
yq -r '.spec.template.spec.initContainers[0].command' | tee /dev/stderr)
yq -r '.spec.template.spec.initContainers[] | select(.name == "client-acl-init") | .command' | tee /dev/stderr)

local actual=$(echo $command | jq -r ' . | any(contains("-tls-server-name=foo"))' | tee /dev/stderr)
[ "${actual}" = "true" ]
Expand All @@ -1360,7 +1360,7 @@ local actual=$(echo $object |
--set 'server.enabled=false' \
--set 'externalServers.hosts[0]=computer' \
. | tee /dev/stderr |
yq -r '.spec.template.spec.initContainers[0].command' | tee /dev/stderr)
yq -r '.spec.template.spec.initContainers[] | select(.name == "client-acl-init") | .command' | tee /dev/stderr)

local actual=$(echo $command | jq -r ' . | any(contains("-tls-server-name"))' | tee /dev/stderr)
[ "${actual}" = "false" ]
Expand All @@ -1375,7 +1375,7 @@ local actual=$(echo $object |
--set 'server.enabled=false' \
--set 'externalServers.hosts[0]=computer' \
. | tee /dev/stderr |
yq -r '.spec.template.spec.initContainers[0].command' | tee /dev/stderr)
yq -r '.spec.template.spec.initContainers[] | select(.name == "client-acl-init") | .command' | tee /dev/stderr)

local actual=$(echo $command | jq -r ' . | any(contains("-use-https"))' | tee /dev/stderr)
[ "${actual}" = "false" ]
Expand All @@ -1391,7 +1391,7 @@ local actual=$(echo $object |
--set 'externalServers.hosts[0]=computer' \
--set 'global.tls.enabled=true' \
. | tee /dev/stderr |
yq -r '.spec.template.spec.initContainers[0].command' | tee /dev/stderr)
yq -r '.spec.template.spec.initContainers[] | select(.name == "client-acl-init") | .command' | tee /dev/stderr)

local actual=$(echo $command | jq -r ' . | any(contains("-use-https"))' | tee /dev/stderr)
[ "${actual}" = "true" ]
Expand All @@ -1407,7 +1407,7 @@ local actual=$(echo $object |
--set 'global.tls.enabled=true' \
--set 'externalServers.hosts[0]=computer' \
. | tee /dev/stderr |
yq -r '.spec.template.spec.initContainers[0].command' | tee /dev/stderr)
yq -r '.spec.template.spec.initContainers[] | select(.name == "client-acl-init") | .command' | tee /dev/stderr)

local actual=$(echo $command | jq -r ' . | any(contains("-use-https"))' | tee /dev/stderr)
[ "${actual}" = "false" ]
Expand All @@ -1422,7 +1422,7 @@ local actual=$(echo $object |
--set 'server.enabled=false' \
--set 'externalServers.hosts[0]=computer' \
. | tee /dev/stderr |
yq -r '.spec.template.spec.initContainers[0].command' | tee /dev/stderr)
yq -r '.spec.template.spec.initContainers[] | select(.name == "client-acl-init") | .command' | tee /dev/stderr)

local actual=$(echo $command | jq -r ' . | any(contains("-server-port"))' | tee /dev/stderr)
[ "${actual}" = "false" ]
Expand All @@ -1437,7 +1437,7 @@ local actual=$(echo $object |
--set 'server.enabled=false' \
--set 'externalServers.hosts[0]=computer' \
. | tee /dev/stderr |
yq -r '.spec.template.spec.initContainers[0].command' | tee /dev/stderr)
yq -r '.spec.template.spec.initContainers[] | select(.name == "client-acl-init") | .command' | tee /dev/stderr)

local actual=$(echo $command | jq -r ' . | any(contains("-server-port"))' | tee /dev/stderr)
[ "${actual}" = "true" ]
Expand All @@ -1453,7 +1453,7 @@ local actual=$(echo $object |
--set 'client.enabled=true' \
--set 'client.exposeGossipPorts=false' \
. | tee /dev/stderr |
yq -r '.spec.template.spec.containers | map(select(.name=="consul")) | .[0].env | map(select(.name=="ADVERTISE_IP")) | .[0] | .valueFrom.fieldRef.fieldPath' |
yq -r '.spec.template.spec.containers[] | select(.name=="consul") | .env[] | select(.name=="ADVERTISE_IP") | .valueFrom.fieldRef.fieldPath' |
tee /dev/stderr)
[ "${actual}" = "status.podIP" ]
}
Expand All @@ -1465,33 +1465,33 @@ local actual=$(echo $object |
--set 'client.enabled=true' \
--set 'client.exposeGossipPorts=true' \
. | tee /dev/stderr |
yq -r '.spec.template.spec.containers | map(select(.name=="consul")) | .[0].env | map(select(.name=="ADVERTISE_IP")) | .[0] | .valueFrom.fieldRef.fieldPath' |
yq -r '.spec.template.spec.containers[] | select(.name=="consul") | .env[] | select(.name=="ADVERTISE_IP") | .valueFrom.fieldRef.fieldPath' |
tee /dev/stderr)
[ "${actual}" = "status.hostIP" ]
}

@test "client/DaemonSet: client doesn't expose hostPorts when client.exposeGossipPorts=false" {
cd `chart_dir`
local actual=$(helm template \
local has_exposed_host_ports=$(helm template \
-s templates/client-daemonset.yaml \
--set 'server.enabled=true' \
--set 'client.enabled=true' \
. | tee /dev/stderr |
yq '.spec.template.spec.containers | map(select(.name=="consul")) | .[0].ports | map(select(.containerPort==8301)) | .[0].hostPort' |
yq '[.spec.template.spec.containers[] | select(.name=="consul") | .ports[] | select(.containerPort==8301)] | any(has("hostPort"))' |
tee /dev/stderr)
[ "${actual}" = "null" ]
[ "${has_exposed_host_ports}" = "false" ]
}

@test "client/DaemonSet: client exposes hostPorts when client.exposeGossipPorts=true" {
cd `chart_dir`
local actual=$(helm template \
local has_exposed_host_ports=$(helm template \
-s templates/client-daemonset.yaml \
--set 'client.enabled=true' \
--set 'client.exposeGossipPorts=true' \
. | tee /dev/stderr |
yq '.spec.template.spec.containers | map(select(.name=="consul")) | .[0].ports | map(select(.containerPort==8301)) | .[0].hostPort' |
yq '[.spec.template.spec.containers[] | select(.name=="consul") | .ports[] | select(.containerPort==8301)] | all(has("hostPort"))' |
tee /dev/stderr)
[ "${actual}" = "8301" ]
[ "${has_exposed_host_ports}" = "true" ]
}

#--------------------------------------------------------------------
Expand All @@ -1503,14 +1503,14 @@ local actual=$(echo $object |
local actual=$(helm template \
-s templates/client-daemonset.yaml \
. | tee /dev/stderr |
yq '.spec.template.spec.volumes[0].hostPath == null' | tee /dev/stderr )
yq '.spec.template.spec.volumes[] | select(.name == "data") | .hostPath == null' | tee /dev/stderr )
[ "${actual}" = "true" ]

# Test that emptyDir is set instead.
local actual=$(helm template \
-s templates/client-daemonset.yaml \
. | tee /dev/stderr |
yq '.spec.template.spec.volumes[0].emptyDir == {}' | tee /dev/stderr )
yq '.spec.template.spec.volumes[] | select(.name == "data") | .emptyDir == {}' | tee /dev/stderr )
[ "${actual}" = "true" ]
}

Expand All @@ -1520,7 +1520,7 @@ local actual=$(echo $object |
-s templates/client-daemonset.yaml \
--set 'client.dataDirectoryHostPath=/opt/consul' \
. | tee /dev/stderr |
yq '.spec.template.spec.volumes[0].hostPath.path == "/opt/consul"' | tee /dev/stderr)
yq '.spec.template.spec.volumes[] | select(.name == "data") | .hostPath.path == "/opt/consul"' | tee /dev/stderr)
[ "${actual}" = "true" ]
}

Expand Down Expand Up @@ -1620,12 +1620,12 @@ rollingUpdate:

@test "client/DaemonSet: securityContext is not set when global.openshift.enabled=true" {
cd `chart_dir`
local actual=$(helm template \
local has_security_context=$(helm template \
-s templates/client-daemonset.yaml \
--set 'global.openshift.enabled=true' \
. | tee /dev/stderr |
yq -r '.spec.template.spec.securityContext' | tee /dev/stderr)
[ "${actual}" = "null" ]
yq -r '.spec.template.spec | has("securityContext")' | tee /dev/stderr)
[ "${has_security_context}" = "false" ]
}

#--------------------------------------------------------------------
Expand Down Expand Up @@ -1682,13 +1682,13 @@ rollingUpdate:
--set 'client.containerSecurityContext.tlsInit.readOnlyRootFileSystem=true' \
. | tee /dev/stderr)

local actual=$(echo "$manifest" | yq -r '.spec.template.spec.containers | map(select(.name == "consul")) | .[0].securityContext.privileged')
local actual=$(echo "$manifest" | yq -r '.spec.template.spec.containers[] | select(.name == "consul") | .securityContext.privileged')
[ "${actual}" = "false" ]

local actual=$(echo "$manifest" | yq -r '.spec.template.spec.initContainers | map(select(.name == "client-acl-init")) | .[0].securityContext.allowPrivilegeEscalation')
local actual=$(echo "$manifest" | yq -r '.spec.template.spec.initContainers[] | select(.name == "client-acl-init") | .securityContext.allowPrivilegeEscalation')
[ "${actual}" = "false" ]

local actual=$(echo "$manifest" | yq -r '.spec.template.spec.initContainers | map(select(.name == "client-tls-init")) | .[0].securityContext.readOnlyRootFileSystem')
local actual=$(echo "$manifest" | yq -r '.spec.template.spec.initContainers[] | select(.name == "client-tls-init") | .securityContext.readOnlyRootFileSystem')
[ "${actual}" = "true" ]
}

Expand All @@ -1708,14 +1708,14 @@ rollingUpdate:
--set 'client.containerSecurityContext.tlsInit.readOnlyRootFileSystem=true' \
. | tee /dev/stderr)

local actual=$(echo "$manifest" | yq -r '.spec.template.spec.containers | map(select(.name == "consul")) | .[0].securityContext')
[ "${actual}" = "null" ]
local has_security_context=$(echo "$manifest" | yq -r '.spec.template.spec.containers[] | select(.name == "consul") | has("securityContext")')
[ "${has_security_context}" = "false" ]

local actual=$(echo "$manifest" | yq -r '.spec.template.spec.initContainers | map(select(.name == "client-acl-init")) | .[0].securityContext')
[ "${actual}" = "null" ]
local has_security_context=$(echo "$manifest" | yq -r '.spec.template.spec.initContainers[] | select(.name == "client-acl-init") | has("securityContext")')
[ "${has_security_context}" = "false" ]

local actual=$(echo "$manifest" | yq -r '.spec.template.spec.initContainers | map(select(.name == "client-tls-init")) | .[0].securityContext')
[ "${actual}" = "null" ]
local has_security_context=$(echo "$manifest" | yq -r '.spec.template.spec.initContainers[] | select(.name == "client-tls-init") | has("securityContext")')
[ "${has_security_context}" = "false" ]
}

#--------------------------------------------------------------------
Expand Down