-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Vault tests to allow more flexibility in mounting PKI and also be more representative of the integration experience of the user #1221
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
604b50a
refactored TestVault
jmurret cdea857
Fixing name of CreateConnectCARootAndIntermediatePIKPolicy to CreateC…
jmurret 89025ba
Modifying TestVault_TlsAutoReload
jmurret 5a20b75
refactored all except WAN Fed has error
jmurret 8af142c
fixing vault wan fed test
jmurret 190732e
fixing snapshot agent vault test
jmurret f84ccf9
comment formatting
jmurret 32f54f5
PR Feedback. Moving vault helper functions to be on the structs they…
jmurret c3eb0ca
update SaveVaultSecretConfiguration to be called KV2Secret
jmurret 71ee4b1
PR Feedback. changing name of Save() onkv2secret to something morede…
jmurret e827ca7
PR feedback- replacing common roles and authmethod path with the use …
jmurret File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -147,13 +147,6 @@ func (v *VaultCluster) bootstrap(t *testing.T, vaultNamespace string) { | |
}) | ||
require.NoError(t, err) | ||
|
||
// Enable the PKI Secrets engine. | ||
err = v.vaultClient.Sys().Mount("pki", &vapi.MountInput{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This has moved to |
||
Type: "pki", | ||
Config: vapi.MountConfigInput{}, | ||
}) | ||
require.NoError(t, err) | ||
|
||
namespace := v.helmOptions.KubectlOptions.Namespace | ||
vaultServerServiceAccountName := fmt.Sprintf("%s-vault", v.releaseName) | ||
v.ConfigureAuthMethod(t, v.vaultClient, "kubernetes", "https://kubernetes.default.svc", vaultServerServiceAccountName, namespace) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This diff is not the easiest to follow unfortunately. The best way to review this is to first gain an understanding of the vault helper functions are used in the tests. So look to the test files first and look for
vault.*
function calls.