Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolving flakey behavior in TestPartitions_Sync with Controller by removing Controller because it is not needed for the test. #1199

Merged
merged 1 commit into from
May 4, 2022
Merged

Resolving flakey behavior in TestPartitions_Sync with Controller by removing Controller because it is not needed for the test. #1199

merged 1 commit into from
May 4, 2022

Conversation

jmurret
Copy link
Member

@jmurret jmurret commented May 2, 2022

Changes proposed in this PR:

  • Remove use of controller from TestPartitions_Sync

How I've tested this PR:

  • running acceptance test locally

How I expect reviewers to test this PR:
👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@jmurret
Resolving flakey behavior in TestPartitions_Sync with Controller by r…
2ebbe2d 
…emoving Controller because it is not needed for the test.
@jmurret jmurret requested review from a team, kschoche and thisisnotashwin and removed request for a team May 2, 2022 20:48
thisisnotashwin
thisisnotashwin approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

kschoche
kschoche approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vaguely recall a similar issue in the past where k8s objects were not getting deployed properly when the controller was enabled and it magically disappeared.
Did you track down why this is happening/fixes it?

@jmurret jmurret closed this May 3, 2022
@jmurret
Copy link
Member Author

jmurret commented May 3, 2022 •
edited
Loading

Closed in favor of: #1202

reopened. Will merge when nightly tests on GKE are green again.

@jmurret jmurret reopened this May 3, 2022
@jmurret jmurret merged commit 6c09ca6 into main May 4, 2022
@jmurret jmurret deleted the jm/partitions-sync-test branch May 4, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschoche kschoche kschoche approved these changes

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmurret @kschoche @thisisnotashwin