Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable configure Connect Injector and Controller Webhooks to be managed by Vault #1191

Merged
merged 80 commits into from
Jun 13, 2022
Merged

Enable configure Connect Injector and Controller Webhooks to be managed by Vault #1191

merged 80 commits into from
Jun 13, 2022

Commits on Jun 13, 2022

  1. refactored TestVault

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    79d97c8 View commit details
    Browse the repository at this point in the history

  2. Fixing name of CreateConnectCARootAndIntermediatePIKPolicy to CreateC… 

    …onnectCARootAndIntermediatePKIPolicy
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    10b507c View commit details
    Browse the repository at this point in the history

  3. refactored all except WAN Fed has error

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    a34ebb7 View commit details
    Browse the repository at this point in the history

  4. fixing vault wan fed test

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    460125d View commit details
    Browse the repository at this point in the history

  5. comment formatting

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    cf61317 View commit details
    Browse the repository at this point in the history

  6. PR Feedback. Moving vault helper functions to be on the structs they … 

    …were taking as arguments.
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    4ecfd7a View commit details
    Browse the repository at this point in the history

  7. PR Feedback. changing name of Save() onkv2secret to something moredes… 

    …criptive. adding comment string.
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    898bf11 View commit details
    Browse the repository at this point in the history

  8. Do not load webhook cert manager when vault is enabled.

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    d192a46 View commit details
    Browse the repository at this point in the history

  9. do not mount volumes when using vault

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    27ca529 View commit details
    Browse the repository at this point in the history

  10. configuring vault injector

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    14c8b0c View commit details
    Browse the repository at this point in the history

  11. Fixing linting

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    c0166f3 View commit details
    Browse the repository at this point in the history

  12. Pods are all running

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    b37191a View commit details
    Browse the repository at this point in the history

  13. Fixing cert-dir paths for vault and non-vault use

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    9a2d56a View commit details
    Browse the repository at this point in the history

  14. fixing volume mount

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    318cca4 View commit details
    Browse the repository at this point in the history

  15. fixing volume mount again

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    768190e View commit details
    Browse the repository at this point in the history

  16. adding bats tests for tls cert directory

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    e9c885d View commit details
    Browse the repository at this point in the history

  17. fixing cert for tls-cert dir

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    2661943 View commit details
    Browse the repository at this point in the history

  18. Adding logic to tests for controller tls cert. also adding snapshot a… 

    …gent and vault namespaces tests
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    a6ea754 View commit details
    Browse the repository at this point in the history

  19. it works...with hardocded stuff...need to refactor from here

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    517f573 View commit details
    Browse the repository at this point in the history

  20. refactoring out the updating of the webhook config

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    d867059 View commit details
    Browse the repository at this point in the history

  21. adding missing file

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    cf4bec7 View commit details
    Browse the repository at this point in the history

  22. adding tests for webhook-cert-manager

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    bbf9616 View commit details
    Browse the repository at this point in the history

  23. refining webhook cert manager to remove setting of global.enablePodSe… 

    …curityPolicies
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    68a7e1a View commit details
    Browse the repository at this point in the history

  24. adding connect-inject bats tests

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    219366d View commit details
    Browse the repository at this point in the history

  25. adding test for controller and use of resource-prefix

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    401ba17 View commit details
    Browse the repository at this point in the history

  26. adding tests for mwc update code

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    8ef4d2b View commit details
    Browse the repository at this point in the history

  27. configure controller to only update mwc with ca bundle when using vau… 

    …lt as a secrets backend.
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    6f8deaf View commit details
    Browse the repository at this point in the history

  28. configure connect inject to only update mwc with ca bundle when using… 

    … vault as a secrets backend.
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    f2ddbf1 View commit details
    Browse the repository at this point in the history

  29. fixing lint errors for unnahdled errors

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    b0d6452 View commit details
    Browse the repository at this point in the history

  30. embedding tlsCertDir for controller and connectInject under vault in … 

    …values.yaml
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    fb16cf1 View commit details
    Browse the repository at this point in the history

  31. embedding tlsCertDir for controller and connectInject under vault in … 

    …values.yaml - fixing tests
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    d9423d6 View commit details
    Browse the repository at this point in the history

  32. change vault role for controller to come from global.secretsBackend.v… 

    …ault.consulControllerCARole
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    c22fe6f View commit details
    Browse the repository at this point in the history

  33. fixing vault namespaces and snapshot agent on vault acceptance tests

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    69688cb View commit details
    Browse the repository at this point in the history

  34. fixing VAULT_TLSAUtoReload test

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    4123629 View commit details
    Browse the repository at this point in the history

  35. rebased fromvault refactor. static server replicaset has error about … 

    …unknown authority.
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    369b265 View commit details
    Browse the repository at this point in the history

  36. Working using separate CAs for connect-injector and controller. only … 

    …vault test is configured.
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    e7664ec View commit details
    Browse the repository at this point in the history

  37. adding failure if .Values.global.secretsBackend.vault.consulConnectIn… 

    …jectCARole, .Values.global.secretsBackend.vault.connectInject.tlsCert, .Values.global.secretsBackend.vault.connectInject.caCert are either all not set or all set.
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    228d2f8 View commit details
    Browse the repository at this point in the history

  38. updating chart with caCert configs

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    1fe928f View commit details
    Browse the repository at this point in the history

  39. enforcing setting both controller and connectInject CA and tls vault … 

    …settings all at once.
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    85eb377 View commit details
    Browse the repository at this point in the history

  40. correcting connect inject tests

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    a982ec9 View commit details
    Browse the repository at this point in the history

  41. Update controller tests

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    a6b52fb View commit details
    Browse the repository at this point in the history

  42. fixing condition on which web certmanager is shut off

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    328ac87 View commit details
    Browse the repository at this point in the history

  43. only rendering vault role when suppled in controller and connect-inje… 

    …ct deployments
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    0bd9666 View commit details
    Browse the repository at this point in the history

  44. fixing connect inject deploy for vault role

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    359fab6 View commit details
    Browse the repository at this point in the history

  45. making global.secretsBackend.vault.consulCARole the fallback in the c… 

    …ontroller and connect-inject deployments if the web cert replacement roles are not defined.
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    84538d9 View commit details
    Browse the repository at this point in the history

  46. Updating the doc string for TestVault_WebhookCerts

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    dfe53c4 View commit details
    Browse the repository at this point in the history

  47. correct rebasing issues

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    75e2248 View commit details
    Browse the repository at this point in the history

  48. removing unneccessary format changes. refactoring consul.serverTLSCAT… 

    …emplate to use consul.vaultCATemplate
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    2c1a2dd View commit details
    Browse the repository at this point in the history

  49. updating test descriptions for webhook-cert-manager resources

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    7450ca5 View commit details
    Browse the repository at this point in the history

  50. updating connect-inject-clusterrole and controller-clusterrole tests

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    d1cdbc7 View commit details
    Browse the repository at this point in the history

  51. updated maybeFailValuesIfVaultWebhookCertSettingsAreIncomplete

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    c061aa8 View commit details
    Browse the repository at this point in the history

  52. Adding Changelog

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    c3b4c2f View commit details
    Browse the repository at this point in the history

  53. Update maybeFailValuesIfVaultWebhookCertSettingsAreIncomplete to vali… 

    …dateVaultWebhookCertConfiguration
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    1ee0d6c View commit details
    Browse the repository at this point in the history

  54. Updating wbhook vault test to make sure that webhook-cert-manager is … 

    …not deployed.
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    91b432c View commit details
    Browse the repository at this point in the history

  55. Fixing the validation that webhook-cert-manager is not running in the… 

    … TestVault_WebhookCerts test
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    23d30b8 View commit details
    Browse the repository at this point in the history

  56. Renamed consulControllerCARole to consulControllerRole and consulCont… 

    …ronnectInjectCARole to consulConnectInjectRole
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    914dfa5 View commit details
    Browse the repository at this point in the history

  57. fixing linting

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    b2db4f1 View commit details
    Browse the repository at this point in the history

  58. Renamed configureCABundleUpdate() to updateWebhookCABundle()

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    130360f View commit details
    Browse the repository at this point in the history

  59. Make ca.crt a constant

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    f7c5023 View commit details
    Browse the repository at this point in the history

  60. Adding doc strings for webhook certs secretName

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    8db287f View commit details
    Browse the repository at this point in the history

  61. updated alt_names for controller and connect inject deployments to be… 

    … the same as they are under web-cert-manager. updated path of where webhook certs get saved.
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    ff519a1 View commit details
    Browse the repository at this point in the history

  62. Change mutatingwebhookconfigurationswhen to mutatingwebhookconfigurat… 

    …ions when
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    a97e041 View commit details
    Browse the repository at this point in the history

  63. added test cases for vault to controller test

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    31884b0 View commit details
    Browse the repository at this point in the history

  64. Webhook certs vault test - checking cert rotation. currently failing.

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    687b99e View commit details
    Browse the repository at this point in the history

  65. moved vault webhook stuff into main vault test and deleted the webhoo… 

    …k cert specific test.
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    282057d View commit details
    Browse the repository at this point in the history

  66. getting rid of lint error

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    26e2c34 View commit details
    Browse the repository at this point in the history

  67. refactoring long conditional in webhook-cert-manager files into a var… 

    …iable for readability
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    dffe549 View commit details
    Browse the repository at this point in the history

  68. addressing PR feedback

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    5ea8b94 View commit details
    Browse the repository at this point in the history

  69. Apply suggestions from code review 

    Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
    @jmurret @ishustava
    jmurret and ishustava committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    fcf5cac View commit details
    Browse the repository at this point in the history

  70. Fixing broken test with retry change

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    ea52b4e View commit details
    Browse the repository at this point in the history

  71. Update charts/consul/templates/_helpers.tpl 

    Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
    @jmurret @ishustava
    jmurret and ishustava committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    43e238a View commit details
    Browse the repository at this point in the history

  72. Removing 127.0.0.1 from ip_sans

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    04ead9c View commit details
    Browse the repository at this point in the history

  73. Removing reference to common_name: Consul Webhook Certificates Service

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    afe0288 View commit details
    Browse the repository at this point in the history

  74. Removing a dangle reference to Consul Webhook Certificates Service

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    fae8c2f View commit details
    Browse the repository at this point in the history

  75. adding 127.0.0.1 back into server ip_sans

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    04bd8d9 View commit details
    Browse the repository at this point in the history

  76. making common name the name of the service for connect-inject and con… 

    …troller
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    81cde1b View commit details
    Browse the repository at this point in the history

  77. Update the description for enable-webhook-ca-update flag in control-p… 

    …lane/subcommand/controller/command.go

Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
    @jmurret @ishustava
    jmurret and ishustava committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    21c2ee7 View commit details
    Browse the repository at this point in the history

  78. Dropping the consul prefix from consulConnectInjectRole and consulCon… 

    …trollerRole
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    5cec9a4 View commit details
    Browse the repository at this point in the history

  79. Updating values.yaml file descriptions for connectInject and controll… 

    …er under vault.
    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    bf9de95 View commit details
    Browse the repository at this point in the history

  80. Updating cert expiry in logging in vault test from RPC expiry.

    @jmurret
    jmurret committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    53b740b View commit details
    Browse the repository at this point in the history