-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ACLs for sync catalog and partitions. #1180
Conversation
2690246
to
837c9ce
Compare
622b0ee
to
f79d04f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice! Acceptance tests are so great!
I only have one nit/question below but don't let it block the PR.
fa7e353
to
a146285
Compare
a146285
to
198dd0a
Compare
// On Kind, there are no load balancers but since all clusters | ||
// share the same node network (docker bridge), we can use | ||
// a NodePort service so that we can access node(s) in a different Kind cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great clarifying comment. 👍🏻
caKeySecretName := fmt.Sprintf("%s-consul-ca-key", releaseName) | ||
|
||
logger.Logf(t, "retrieving ca cert secret %s from the server cluster and applying to the client cluster", caCertSecretName) | ||
moveSecret(t, serverClusterContext, clientClusterContext, caCertSecretName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you didn't add this function, but I'm wondering if it might be clearer if it were called copySecret
. "Move" makes me think that the original instance is no longer there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
82d0a90
to
80d802c
Compare
f80533d
to
04597d4
Compare
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: