Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup EKS VPC peering connections #1173

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Cleanup EKS VPC peering connections #1173

merged 2 commits into from
Apr 15, 2022

Conversation

ndhanushkodi
Copy link
Contributor

Changes proposed in this PR:

  • Currently if you run terraform apply with cluster count of 2, and then run our cleanup script, it will fail because VPCs can't get deleted since they have a dependency on peering connections
  • This allows you to run the cleanup script successfully, by deleting peering conns

How I've tested this PR:

  • Ran script after terraforming 2 eks clusters, and saw it succeed.

How I expect reviewers to test this PR:
👀

@ndhanushkodi ndhanushkodi requested review from a team, curtbushko, t-eckert and thisisnotashwin and removed request for a team and t-eckert April 14, 2022 22:35
thisisnotashwin
thisisnotashwin approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for doing this!!

ishustava
ishustava approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@ndhanushkodi ndhanushkodi merged commit a9357c3 into main Apr 15, 2022
@ndhanushkodi ndhanushkodi deleted the fix-eks-cleanup branch April 15, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishustava ishustava ishustava approved these changes

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

@curtbushko curtbushko Awaiting requested review from curtbushko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndhanushkodi @ishustava @thisisnotashwin