Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get federation secret from any of the places it is set. #1154

Merged
merged 5 commits into from
Apr 11, 2022

Conversation

t-eckert
Copy link
Contributor

@t-eckert t-eckert commented Apr 8, 2022

Changes proposed in this PR:

  • When installing a federated cluster, the install command will look in all of the places the name of the federation secret could be set and return the first set value it finds.

How I've tested this PR:

Added unit tests, ran the install tests which exercise the presence of the fed secret.

How I expect reviewers to test this PR:

Running the unit tests as well if you like.

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@t-eckert t-eckert requested review from a team, curtbushko and ndhanushkodi and removed request for a team April 8, 2022 16:39
cli/release/release.go Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
Copy link
Member

@jmurret jmurret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 nice work!

@t-eckert t-eckert merged commit edbf3ff into main Apr 11, 2022
@t-eckert t-eckert deleted the cli/fix-finding-fed-secret branch April 11, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants