Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making changes to values.yaml for docs generation based on docs PR feedback. #1131

Merged
merged 4 commits into from
Apr 4, 2022
Merged

Making changes to values.yaml for docs generation based on docs PR feedback. #1131

merged 4 commits into from
Apr 4, 2022

Conversation

jmurret
Copy link
Member

@jmurret jmurret commented Mar 31, 2022

Changes proposed in this PR:

  • Comment changes based on feedback in this docs PR

How I've tested this PR:

  • generated docs and had them approved by docs team

How I expect reviewers to test this PR:

  • 👀

@jmurret jmurret marked this pull request as ready for review April 4, 2022 20:26
t-eckert
t-eckert approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@t-eckert t-eckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement to the copy here.

@t-eckert t-eckert merged commit d2ce375 into main Apr 4, 2022
@t-eckert t-eckert deleted the jm/helm-updates branch April 4, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtbushko curtbushko curtbushko approved these changes

@t-eckert t-eckert t-eckert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmurret @curtbushko @t-eckert