Add annotation to mount connect inject volume to other containers #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding one more reviewer since this is a community PR that I already reviewed. |
lkysow
force-pushed
the
lkysow/inject-volume-mount
branch
from
0eb449f
to
256b634
Compare
ishustava
approved these changes
Apr 12, 2022
david-yu
pushed a commit
that referenced
this pull request
Apr 13, 2022
2 tasks
lkysow
pushed a commit
that referenced
this pull request
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just resolving conflicts from #763
Changes proposed in this PR:
Discussion in #761
Fixes #761
How I've tested this PR: Unit tests and manual tests
How I expect reviewers to test this PR: Manually add annotation to pods and see if volume gets mounted.
Checklist: