Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile: bump to alpine 3.15 #1058

Merged
merged 4 commits into from
Feb 25, 2022
Merged

Dockerfile: bump to alpine 3.15 #1058

merged 4 commits into from
Feb 25, 2022

Conversation

david-yu
Copy link
Contributor

@david-yu david-yu commented Feb 24, 2022 •
edited
Loading

Changes proposed in this PR:

  • Bump consul-k8s-control-plane alpine base image to 3.15

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

Dockerfile: bump to alpine 3.15
fa32767 
Bump control plane to 3.15
@david-yu david-yu requested review from a team, jmurret and thisisnotashwin and removed request for a team February 24, 2022 22:15
jmurret
jmurret approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@jmurret jmurret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 🎉

t-eckert
t-eckert approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@t-eckert t-eckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for handling this!

@david-yu david-yu merged commit f8ae1ff into main Feb 25, 2022
@david-yu david-yu deleted the david-yu-alpine branch February 25, 2022 21:21
geobeau pushed a commit to geobeau/consul-k8s that referenced this pull request May 20, 2022
@ishustava
acceptance-tests: disable DNS by default in tests to avoid false posi…
1eaabb7 
…tives (hashicorp#1058)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmurret jmurret jmurret approved these changes

@t-eckert t-eckert t-eckert approved these changes

@thisisnotashwin thisisnotashwin Awaiting requested review from thisisnotashwin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david-yu @jmurret @t-eckert