Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chart: bump k8s requirement to 1.19 #1049

Merged
merged 6 commits into from
Feb 24, 2022
Merged

chart: bump k8s requirement to 1.19 #1049

merged 6 commits into from
Feb 24, 2022

Conversation

david-yu
Copy link
Contributor

@david-yu david-yu commented Feb 23, 2022 •
edited
Loading

Changes proposed in this PR:

  • bump kubeVersionAPI to 1.19 to reflect what we see in README
  • default to using ingressClassName value
  • remove bats tests for 1.19 on UI Ingress and remove --kube-version flags since tests run on 1.19+ by default

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@david-yu david-yu marked this pull request as ready for review February 23, 2022 20:00
thisisnotashwin
thisisnotashwin approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAYY!!

t-eckert
t-eckert approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@t-eckert t-eckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The future is here!

@david-yu
Copy link
Contributor Author

Will add a follow up changelog to this, will merge now.

@david-yu david-yu merged commit a5516c9 into main Feb 24, 2022
@david-yu david-yu deleted the david-yu-k8s_1_19_bump branch February 24, 2022 18:35
@david-yu david-yu mentioned this pull request Feb 24, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

@t-eckert t-eckert t-eckert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david-yu @thisisnotashwin @t-eckert