Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add godot linter and fix issues #1042

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Add godot linter and fix issues #1042

merged 1 commit into from
Feb 22, 2022

Conversation

ishustava
Copy link
Contributor

Changes proposed in this PR:

  • Add a linter to check that we have dots at the end of godoc comments
  • Add makefile targets for linters

How I've tested this PR:
ran linter locally

How I expect reviewers to test this PR:
👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@ishustava ishustava requested review from a team, curtbushko and t-eckert and removed request for a team February 22, 2022 19:00
Copy link
Member

@jmurret jmurret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 🎉

Also, add makefile targets for linters
Copy link
Contributor

@t-eckert t-eckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@ishustava ishustava merged commit 8424526 into main Feb 22, 2022
@ishustava ishustava deleted the ishustava/godot-linter branch February 22, 2022 19:59
geobeau pushed a commit to geobeau/consul-k8s that referenced this pull request May 20, 2022
…in extraConfig (hashicorp#1042)

* add host_ip as an env variable, evaluate HOST_IP/POD_IP/HOSTNAME at runtime and add new config file for server and client

Co-authored-by: Ashwin Venkatesh <ashwin@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants