Add support for api gateway + consul namespaces #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewstucki
requested review from
nickethier,
lkysow,
mikemorris and
nathancoleman
nathancoleman
requested review from
a team and
ishustava
and removed request for
a team
nathancoleman
approved these changes
Feb 22, 2022
mikemorris
reviewed
Feb 22, 2022
There was a problem hiding this comment.
LGTM from the API Gateway side, would appreciate a final review from @hc-github-team-consul-ecosystem before merging.
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
geobeau
pushed a commit
to geobeau/consul-k8s
that referenced
this pull request
May 20, 2022
… is offline (hashicorp#1024) * Fail scheduling all pods that are not part of consul when the webhook is unhealthy. Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, coinciding with the corresponding PR in the api gateway codebase adds support for namespace mapping of deployed gateways.
More context around the usage envisioned is in that PR, but for the most part this copies the same configuration as used in the connect injection and catalog sync helm configuration.
Tested via
bats: