Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>
  • Loading branch information
missylbytes and nathancoleman authored Aug 8, 2023
1 parent 72eb032 commit cbb7409
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion control-plane/api-gateway/binding/result.go
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ var (
// direct port conflicts defined by the user (two listeners on the same port) vs a port conflict because we map
// privileged ports by adding the value passed into the gatewayClassConfig.
// (i.e. one listener on 80 with a privileged port mapping of 2000, and one listener on 2080 would conflict).
errListenerMappedToPrivilegedPortMapping = errors.New("listener conflicts with privileged port mapped by Gateway Class Config privileged port mapping setting")
errListenerMappedToPrivilegedPortMapping = errors.New("listener conflicts with privileged port mapped by GatewayClassConfig privileged port mapping setting")
)

// listenerValidationResult contains the result of internally validating a single listener
Expand Down
2 changes: 2 additions & 0 deletions control-plane/api-gateway/common/helm_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ type HelmConfig struct {
// and should create SecurityContextConstraints.
EnableOpenShift bool

// MapPrivilegedServicePorts is the value which Consul will add to privileged container port values (ports < 1024)
// defined on a Gateway.
MapPrivilegedServicePorts int
}

Expand Down

0 comments on commit cbb7409

Please sign in to comment.