Skip to content

Commit

Permalink
cleanup testing comments
Browse files Browse the repository at this point in the history
  • Loading branch information
NiniOak committed Mar 8, 2024
1 parent be2f529 commit 8607b3d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 11 deletions.
12 changes: 4 additions & 8 deletions .github/workflows/nightly-cleanup.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
# Dispatch to the consul-k8s-workflows with a nightly cron
name: nightly-cleanup
on:
push:
branches:
# REMOVE MEEEEE - Testing only
- "NET-8391_fix_eks_cleanup"
# schedule:
# # * is a special character in YAML so you have to quote this string
# # Run nightly at 12PM UTC/8AM EST/5AM PST
# - cron: '0 12 * * *'
schedule:
# * is a special character in YAML so you have to quote this string
# Run nightly at 12PM UTC/8AM EST/5AM PST
- cron: '0 12 * * *'

# these should be the only settings that you will ever need to change
env:
Expand Down
6 changes: 3 additions & 3 deletions hack/aws-acceptance-test-cleanup/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ func realMain(ctx context.Context) error {
vpcName, _ := vpcNameAndBuildURL(vpc)
cluster, ok := toDeleteClusters[vpcName]
if !ok {
fmt.Printf("Found no associated EKS cluster for VPC: %s\n", *vpc.VpcId)
fmt.Printf("Found no associated EKS cluster for VPC: %s\n", vpcName)
} else {
// Delete node groups.
nodeGroups, err := eksClient.ListNodegroupsWithContext(ctx, &eks.ListNodegroupsInput{
Expand Down Expand Up @@ -382,7 +382,7 @@ func realMain(ctx context.Context) error {
},
},
})

if err != nil {
return err
}
Expand Down Expand Up @@ -495,7 +495,7 @@ func realMain(ctx context.Context) error {
if err != nil {
return err
}

for _, igw := range igws.InternetGateways {
fmt.Printf("Internet gateway: Detaching from VPC... [id=%s]\n", *igw.InternetGatewayId)
if err := destroyBackoff(ctx, "Internet Gateway", *igw.InternetGatewayId, func() error {
Expand Down

0 comments on commit 8607b3d

Please sign in to comment.