Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Enable metrics acceptance tests #896

Merged
merged 8 commits into from
Apr 7, 2021
Merged

Conversation

ndhanushkodi
Copy link
Contributor

@ndhanushkodi ndhanushkodi commented Apr 6, 2021

Changes proposed in this PR:

  • Adds changes to metrics acceptance tests so we can enable them.

How I've tested this PR:

  • Running acceptance tests

How I expect reviewers to test this PR:

  • Code review

@ndhanushkodi ndhanushkodi marked this pull request as draft April 6, 2021 21:31
@ishustava ishustava force-pushed the enable-endpoints-controller branch from 270e660 to fd2e0a7 Compare April 6, 2021 22:07
@ndhanushkodi ndhanushkodi marked this pull request as ready for review April 6, 2021 22:28
@ndhanushkodi ndhanushkodi requested review from a team, lkysow and ishustava and removed request for a team April 6, 2021 22:29
Base automatically changed from enable-endpoints-controller to feature-tproxy April 6, 2021 23:45
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!

It just needs to be rebased as I've just merged #886 to feature-tproxy 🤭

@ndhanushkodi ndhanushkodi force-pushed the enable-metrics-tests branch 2 times, most recently from a48f2a1 to 7ba3def Compare April 7, 2021 04:47
@ndhanushkodi ndhanushkodi merged commit 500e6c1 into feature-tproxy Apr 7, 2021
@ndhanushkodi ndhanushkodi deleted the enable-metrics-tests branch April 7, 2021 16:40
thisisnotashwin pushed a commit that referenced this pull request Apr 15, 2021
Enable metrics acceptance tests
ishustava pushed a commit that referenced this pull request Apr 16, 2021
Enable metrics acceptance tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants