This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishustava
force-pushed
the
enable-endpoints-controller
branch
from
April 6, 2021 22:07
270e660
to
fd2e0a7
Compare
ndhanushkodi
force-pushed
the
enable-metrics-tests
branch
from
April 6, 2021 22:21
509dd65
to
07b4cee
Compare
ndhanushkodi
requested review from
a team,
lkysow and
ishustava
and removed request for
a team
April 6, 2021 22:29
lkysow
approved these changes
Apr 6, 2021
test/acceptance/tests/fixtures/bases/static-metrics-app/service.yaml
Outdated
Show resolved
Hide resolved
ndhanushkodi
force-pushed
the
enable-metrics-tests
branch
from
April 6, 2021 22:57
07b4cee
to
52da0d5
Compare
ishustava
approved these changes
Apr 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!!
It just needs to be rebased as I've just merged #886 to feature-tproxy 🤭
ndhanushkodi
force-pushed
the
enable-metrics-tests
branch
2 times, most recently
from
April 7, 2021 04:47
a48f2a1
to
7ba3def
Compare
ndhanushkodi
force-pushed
the
enable-metrics-tests
branch
from
April 7, 2021 04:48
7ba3def
to
577430b
Compare
thisisnotashwin
pushed a commit
that referenced
this pull request
Apr 15, 2021
Enable metrics acceptance tests
ishustava
pushed a commit
that referenced
this pull request
Apr 16, 2021
Enable metrics acceptance tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR: