This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
acceptance-tests: disable DNS by default in tests to avoid false positives #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ishustava
force-pushed
the
acceptance-tests-disable-dns
branch
from
7609ce1
to
76119e4
Compare
ishustava
requested review from
a team,
ndhanushkodi and
thisisnotashwin
and removed request for
a team
ishustava
commented
Jul 27, 2021
| @@ -55,7 +55,7 @@ commands: | |||
| type: string | |||
| consul-k8s-image: | |||
| type: string | |||
| default: "docker.mirror.hashicorp.services/hashicorpdev/consul-k8s:latest" | |||
| default: "hashicorpdev/consul-k8s:2dfffed" | |||
There was a problem hiding this comment.
undo when hashicorp/consul-k8s#576 is merged
thisisnotashwin
approved these changes
Jul 27, 2021
ndhanushkodi
approved these changes
Jul 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
🐢
How I expect reviewers to test this PR:
Checklist: