Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of Add emit_tags_as_labels setting to envoy metrics service cfg into release/1.2.x #198

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Backport of Add emit_tags_as_labels setting to envoy metrics service cfg into release/1.2.x #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41090a8
backport of commit 244265ca19e6d8574e8d328080005294fb6a88fc
Jun 27, 2023
32a145b
backport of commit 67aa49b7557008ebbbce406fde0b424a2913167d
Jun 27, 2023
71d4062
backport of commit 955e2c65102ec1e7d567f6ade3835db31070bcfa
Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/184.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:improvement
connect: Add capture group labels from Envoy cluster FQDNs to Envoy exported metric labels
```
3 changes: 2 additions & 1 deletion internal/bootstrap/bootstrap_config.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions internal/bootstrap/bootstrap_config_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pkg/consuldp/testdata/TestBootstrapConfig/hcp-metrics.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@
"envoy_grpc": {
"cluster_name": "consul_telemetry_collector_loopback"
}
}
},
"emit_tags_as_labels": true
}
}
],
Expand Down