fix(connect): set initial_fetch_time to wait indefinitely #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashi-derek
approved these changes
Jul 10, 2023
This was referenced Jul 10, 2023
DanStough
added
backport/1.1
This was referenced Jul 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt 2 at closing hashicorp/consul#17283
Because we use the default initial_fetch_timeout in the Envoy bootstrap, not all Envoy resources may be loaded in busy systems. However, we previously relied on the timeout to start ingress and API gateways. This PR changes the default initial_fetch_timeout to wait indefinitely "0s".
The Consul PR that updates the snapshot functionality is below.
Links
Consul PR