-
Notifications
You must be signed in to change notification settings - Fork 16
referencepolicy: finish backwards compatibility support and tests #293
Conversation
…refer to ReferenceGrant
… to Gateway requests
}) | ||
} | ||
refGrants = append(refGrants, refGrant) | ||
refGrants = append(refGrants, gwv1alpha2.ReferenceGrant{Spec: refPolicy.Spec}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e tests for Gateway CertificateRefs, HTTPRoute, and TCPRoute ReferencePolicy backwards compatibility fail as expected when this line is commented out, so the test coverage gap that existed when #280 was discovered is covered now.
b79cbeb
to
a25c4a9
Compare
…and TCPRoute BackendRefs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will there be a point in time when referencepolicy is expected to fail, or will it keep working with the warning indefinitely?
I believe the upstream plan is to remove ReferencePolicy in the next minor (v0.6.0) Gateway API release, so we would likely remove support when upgrading to that - could be several months out though. |
Changes proposed in this PR:
Spec
field.How I've tested this PR:
CI tests should still be passing after changes.
How I expect reviewers to test this PR:
Verify changes make sense and sufficiently cover support.
Checklist:
CHANGELOG entry added