This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
ci: update binary build Go version to 1.18.1 #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemorris
added
the
pr/no-changelog
nathancoleman
approved these changes
May 2, 2022
There was a problem hiding this comment.
Noting that we pinned everything else to the minor version 1.18 in #167 . Why the patch version here?
|
Re patch version, we discussed as a team how pinning an exact version makes it easier to see exactly what Go version a binary was published with when looking through commit history without needing to introspect the actual binary, but still want to be testing against latest in CI to catch any breaking changes early. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #167 (comment) (which already added a changelog entry for this)