This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
http-route-controller: watch ReferencePolicy lifecycle #156
Merged
Merged
Changes from 46 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
c45e435
refpolicy: add ReferencePolicy watch and draft of filtering logic to …
mikemorris 4a9a922
gatewayclient: add GetHTTPRoutes
mikemorris a70a80a
refpolicy: comment out unused logic, use gatewayclient.GetHTTPRoutes
mikemorris b34ccc2
gatewayclient: add mock for GetHTTPRoutes
mikemorris 5cfb359
gatewayclient: return []HTTPRoute from GetHTTPRoutes instead of HTTPR…
mikemorris 82e9b75
fixup: use []HTTPRoute instead of HTTPRouteList.Items
mikemorris 44758a0
gatewayclient: add test for GetHTTPRoutes
mikemorris c907b46
refpolicy: update comment on how events are mapped to watch handler
mikemorris ba59367
refpolicy: begin adding test for route controller watch
mikemorris 4a52f31
refpolicy: add failing referencePolicyToRouteRequests test
mikemorris 26c3558
refpolicy: start adding logging for referencePolicyToRouteRequests
mikemorris dbb3f36
refpolicy: add FIXME comment to failing test
mikemorris af69251
fixup
mikemorris 7aa53be
refpolicy: always return []reconcile.Request from referencePolicyTpRo…
mikemorris 285f531
refpolicy: add FIXMEs to convert to client.MatchingLabels
mikemorris f3e8b48
refpolicy: get test passing by triggering reconciliation only on HTTP…
mikemorris be82195
fixup field selector
mikemorris fae9262
gatewayclient: fixup test for GetHTTPRoutesInNamespace
mikemorris 7340e4c
httproutereconciler: comment out unused toSelectors
mikemorris 7acd89d
Update internal/k8s/controllers/http_route_controller_test.go
mikemorris 286297c
Update internal/k8s/controllers/http_route_controller_test.go
mikemorris 9efb16e
e2e: create two namespaces in stack
mikemorris d0819fd
e2e: add beginning of ReferencePolicy lifecycle test
mikemorris acab615
fixup: routeOneName -> routeName
mikemorris 0453a5a
e2e: implement rest of ReferencePolicy lifecycle test
mikemorris 98309ba
fixup: fix syntax errors in createConditionCheck
mikemorris d92b2be
fixup: fix route namespace for httpRouteStatusCheck
mikemorris b2528b1
e2e: add FIXME comments to work around controller deleting invalid route
mikemorris 07b7d04
fixup: comment out unused httpRouteStatusCheck
mikemorris a37cfd1
e2e: add ReferencePolicy to schema known types
mikemorris ecab6ca
fixup: add ReferencePolicy metadata.name
mikemorris 43c4ab4
cleanup: refactor condition checks to use createConditionCheck
mikemorris 67e05e2
e2e: add debug logging for route creation
mikemorris 46e9ea5
e2e: add gateway namespace to parentRef for route in ReferencePolicy …
mikemorris 42a8756
e2e: clean up debugging, add createConditionsCheck
mikemorris 18f5902
e2e: refactor checks into createConditionsCheck
mikemorris 5f1545e
httproutecontroller: switch reconcile request helper signatures to ta…
mikemorris 5cb3cbc
httproutecontroller: log error in getReferencePolicyObjectsFrom
mikemorris 8eb2e30
httproutecontroller: plumb context through HTTPRouteController struct
mikemorris 59be45d
e2e: revert changes to SetNamespace and Namespace environment helpers
mikemorris 185fdf6
e2e: add HTTPReferencePolicyPort
mikemorris 768af2a
bugfix: check for correct conditionReady, uncovered by fixing conditi…
mikemorris 1742d81
Update internal/k8s/controllers/http_route_controller.go
mikemorris 8836a01
Update internal/k8s/controllers/http_route_controller.go
mikemorris d778557
httproutecontroller: remove toSelector ReferencePolicy filtering logic
mikemorris dc8e1cd
httproutecontroller: remove unused groupKindToFieldSelector func
mikemorris 6484db6
changelog: add changelog entry for HTTPRouteController ReferencePolic…
mikemorris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor uncovered that this should've been
&&
, so this check was erroneously passing on any condition withStatus: "True"
, and was being called in a few places whereconditionReady
should have been called instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find!