Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(host): Add host set information to static host #1828

Merged
merged 4 commits into from
Feb 1, 2022
Merged

feat(host): Add host set information to static host #1828

merged 4 commits into from
Feb 1, 2022

Conversation

A-440Hz
Copy link
Contributor

@A-440Hz A-440Hz commented Jan 25, 2022

Updates LookupHost and ListHost API to include sets a static host is part of, as like with plugin hosts.

talanknight
talanknight suggested changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@talanknight talanknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also return the host's sets as a response to the UpdateHost call.

internal/db/schema/migrations/oss/postgres/25/01_static_host_view.up.sql Show resolved Hide resolved
internal/servers/controller/handlers/hosts/host_service_test.go Outdated Show resolved Hide resolved
internal/servers/controller/handlers/hosts/host_service_test.go Show resolved Hide resolved
louisruch
louisruch requested changes Jan 27, 2022
View reviewed changes
Copy link
Collaborator

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! I left a couple of nits and comments, lets chat tomorrow about updating the interface!

internal/host/static/host.go Outdated Show resolved Hide resolved
internal/host/static/host.go Show resolved Hide resolved
internal/host/static/host.go Show resolved Hide resolved
internal/host/static/repository_host.go Outdated Show resolved Hide resolved
internal/servers/controller/handlers/hosts/host_service.go Outdated Show resolved Hide resolved
internal/servers/controller/handlers/hosts/host_service.go Outdated Show resolved Hide resolved
@A-440Hz
feat(host): Add host set information to static host
7967c47 
Updates LookupHost and ListHost API to include sets a static host is part of, as like with plugin hosts.
@A-440Hz A-440Hz force-pushed the read-static-hostsets branch from ddb15a5 to 1d52924 Compare January 28, 2022 19:24
@A-440Hz A-440Hz requested a review from talanknight January 28, 2022 20:51
talanknight
talanknight suggested changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@talanknight talanknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress!

internal/host/static/repository_host.go Outdated Show resolved Hide resolved
internal/servers/controller/handlers/hosts/host_service_test.go Show resolved Hide resolved
internal/host/static/repository_host_test.go Show resolved Hide resolved
internal/tests/api/hostsets/host_set_test.go Outdated Show resolved Hide resolved
internal/tests/api/hostsets/host_set_test.go Outdated Show resolved Hide resolved
@A-440Hz A-440Hz force-pushed the read-static-hostsets branch from 1d52924 to f6ab326 Compare January 29, 2022 04:15
talanknight
talanknight suggested changes Jan 31, 2022
View reviewed changes
internal/host/static/repository_host_test.go Outdated Show resolved Hide resolved
internal/host/static/repository_host_test.go Outdated Show resolved Hide resolved
internal/host/static/repository_host_test.go Outdated Show resolved Hide resolved
internal/host/static/repository_host_test.go Show resolved Hide resolved
internal/host/static/repository_host_test.go Outdated Show resolved Hide resolved
internal/servers/controller/handlers/hosts/host_service.go Outdated Show resolved Hide resolved
@A-440Hz A-440Hz requested a review from talanknight January 31, 2022 22:57
talanknight
talanknight suggested changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@talanknight talanknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks close!

internal/host/static/repository_host_test.go Outdated Show resolved Hide resolved
internal/servers/controller/handlers/hosts/host_service.go Show resolved Hide resolved
talanknight
talanknight approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@talanknight talanknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Please remember to ensure the db directory doesn't conflict with one that might have already been submitted.

@A-440Hz A-440Hz merged commit fa00a06 into main Feb 1, 2022
@A-440Hz A-440Hz deleted the read-static-hostsets branch February 1, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talanknight talanknight talanknight approved these changes

@louisruch louisruch Awaiting requested review from louisruch

Assignees
No one assigned
Labels
core/db core/host core/servers core/sql core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@A-440Hz @talanknight @louisruch