-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Updates to gcp hc form #2649
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
note: worker_filter is ent only field, so I will be wrapping this field with a flag, moving to draft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Thanks for the work 🙌
Co-authored-by: Zhihe Li <zhihe.li@hashicorp.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* chore: 🤖 add worker_filter field, updates to helper text
* chore: 🤖 add worker_filter field, updates to helper text
Description
This PR adds
worker_filter
field and updates the copy forprivate_key
fieldScreenshots (if appropriate)
How to Test
Checklist
[ ] I have added JSON response output for API changes[ ] I have added steps to reproduce and test for bug fixes in the description[ ] I have commented on my code, particularly in hard-to-understand areas[ ] I have added tests that prove my fix is effective or that my feature works