Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updates to gcp hc form #2649

Merged
merged 6 commits into from
Jan 9, 2025
Merged

Conversation

DhariniJeeva
Copy link
Collaborator

@DhariniJeeva DhariniJeeva commented Jan 8, 2025

Description

This PR adds worker_filter field and updates the copy for private_key field

Screenshots (if appropriate)

Screenshot 2025-01-09 at 1 35 22 PM

How to Test

Checklist

  • I have added before and after screenshots for UI changes
  • [ ] I have added JSON response output for API changes
  • [ ] I have added steps to reproduce and test for bug fixes in the description
  • [ ] I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works

@DhariniJeeva DhariniJeeva requested a review from a team as a code owner January 8, 2025 20:41
Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 10:23pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 10:23pm

@DhariniJeeva DhariniJeeva self-assigned this Jan 8, 2025
@DhariniJeeva
Copy link
Collaborator Author

note: worker_filter is ent only field, so I will be wrapping this field with a flag, moving to draft

@DhariniJeeva DhariniJeeva marked this pull request as draft January 8, 2025 21:45
calcaide
calcaide previously approved these changes Jan 8, 2025
Copy link
Collaborator

@calcaide calcaide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks for the work 🙌

@DhariniJeeva DhariniJeeva added this to the 0.19.0 milestone Jan 9, 2025
calcaide
calcaide previously approved these changes Jan 9, 2025
ZedLi
ZedLi previously approved these changes Jan 9, 2025
addons/api/mirage/factories/host-catalog.js Outdated Show resolved Hide resolved
Co-authored-by: Zhihe Li <zhihe.li@hashicorp.com>
Copy link
Collaborator

@cameronperera cameronperera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DhariniJeeva DhariniJeeva merged commit 1f51efb into llb/gcp-plugin Jan 9, 2025
10 checks passed
@DhariniJeeva DhariniJeeva deleted the updates-to-gcp-hc-form branch January 9, 2025 22:54
DhariniJeeva added a commit that referenced this pull request Jan 10, 2025
* chore: 🤖 add worker_filter field, updates to helper text
DhariniJeeva added a commit that referenced this pull request Jan 10, 2025
* chore: 🤖 add worker_filter field, updates to helper text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants